Inconsistent XP drops for Shadow Warriors/Guards thus breaking RSC+ feature

[Dinsdale]

Hi guys

Tried to make a support ticket on GitHub but it was just hanging when clicking "Create issue".

I believe there may be a bug with my character and/or the RSC+ client itself that is causing a feature of RSC Client to be unusable in some scenarios.

I am confident RSC+ is the symptom, but not the cause.

Summary
The bug is that XP drops for Shadow Warriors and Guards (that I know of) have suddenly become consistently inconsistent. This hampers the functionality/convenience of the "Actions until Level/Actions until Goal" feature when hovering over the XP bar because it (correctly) calculates the inconsistent XP drops.

I fight with the Controlled style. I have killed over 101k Shadow Warriors, and always received 36.5XP in Attack, Strength, Defense, and Hits for each kill. Recently, I went back to training combat, which incidentally was shortly after a server restart for unrelated reasons (this may well be a red herring but thought I'd mention it incase this is solved with a simple reboot.)

Now, the first kill will give me 36.0XP in ASDH. However, the second kill will give me 37.0XP in ASDH. The third will give 36.0XP, the fourth will give 37.0XP and so on. This means that on average, it is still 36.5XP per kill, but as mentioned above, my target actions to level will never go down in single digit which would be expected behaviour and indeed was the behaviour experienced for the first 101k kills.

Testing/Replicating
- I asked another player to kill some Shadow Warriors using the Controlled stance. He killed 3 Shadow Warriors, and received 36.5XP each time - which mirrors the expected behaviour I previously experienced.
- I killed other monsters and they all gave their XP drops consistently - Giant Bats (21.0XP), Pit Scorpion (23.0XP), Imp (7.0XP), Gunthor the Brave (23.5), Barbarian (13.0XP), Dwarf (14.0XP).
- I then did further tests with a guard, who, like the Shadow Warrior, has either .5 or .75 XP after it. A Guard gave 19.0XP and then 20.0XP inconsistently too. I believe this is because the XP it should give off are 19.5XP - a similar scenario to Shadow Warriors

Test Results
Guard after first kill gave 19XP
Before: 4,216,251.0XP
After: 4,216,270.0XP
Difference: 19.0XP

Guard after second kill gave 20XP
Before: 4,216,270.0XP
After: 4,216,2590.0XP
Difference: 20.0XP

After killing a couple of more monsters, I tried the same thing with the Shadow Warriors and captured screenshots, which I've attached.

Shadow Warrior after first kill gave 36XP (Screenshot A)
Before: 4,216,384.0XP
After: 4,216,420.0XP
Difference: 36.0XP

Shadow Warrior after second kill gave 37XP (Screenshot B)
Before: 4,216,420.0XP
After: 4,216,457.0XP
Difference: 37.0XP


What is interesting, is that when I use the "::hits" command, the message says "My Hits level is 87 (4,216,457.0XP)." This is matched with what the RSC+ Client reports, but the actual stats when I hover over says 4,216,456.0XP (Screenshot C)

Desired Outcome
The outcome that I'd ideally like by reporting this bug is to return to consistent XP drops for every monster and thus making the "Actions until Level/Actions until Goal" feature usable no matter what monsters I choose to train combat with.

I also believe one issue with my account is that somehow, someway, whether it be a server glitch or something, that the hidden XP in the 2nd decimal place onwards for Attack, Strength, Defense, and Hits is not divisible by .25 . If these 4 can be rounded down at a server level to the nearest .00, that may solve the issue and the RSC+ can apply the calculation of the consistent XP drops, thus accomplishing the desired outcome.

Hope this makes logical sense and happy to do further tests or answer any questions.

Thanks
Dinsdale (account name)
Player ID: 41784

[Ryan]

Hello,

These are my thoughts without looking at any code.

The big thing is that your character isn't glitched. XP is shown to you in game differently to how it's stored in the database. Your stored XP is 4 times higher than what you see in the client. This way, you can have decimal XP values on the client without any of the issues that arise with floating point arithmetic/comparisons. So you're definitely not on an XP value that isn't divisible by 0.25.

So, my current best guess is that because your (stored) XP is currently divisible by 4, but not by 2 (in other words, your current XP is divisible by 0.25 but not by 0.5), that's why you're seeing this issue. I assume that the RSC+ feature will round up when your XP ends in 0.75, but the original game will floor your XP value, which is why it shows lower in the stats menu.

So my proposed fix is to find something that, when killed, grants an XP value that ends in .25 or .75.

If it's not that, then perhaps we can take a closer look.

[Dinsdale]

Thanks for your reply. I see what you're saying.

I did as you suggested, and it is I expected. It solves the issues with the Shadow Warriors, but swaps the issue with any other monster not with the same division.

Can I suggest another possible fix? Could I suggest that the XP at the database level for Attack, Strength, Defense, and Hits are all simultaneously rounded down to the nearest full point manually to see if that works?